rust-bitcoin / bitcoind

Utility to launch a regtest bitcoind process in a rust test
MIT License
41 stars 35 forks source link

Use range dependencies #158

Closed tcharding closed 7 months ago

tcharding commented 7 months ago

The last couple of releases of bitcoincore-rpc and bitcoin_hashes have not required code changes here. This means we can use range dependencies. The benefit is that it makes the upgrade of other crates that use bitcoind easier.

Tested by pinning hashes with:

And then pinning bitcoincore-rpc with all of the dependencies in the range and running cargo check --all --all-features --all-targets

E.g (using cc as alias to the cargo check command above)

Bump the crate patch version so we can release this change in a point release. Since this is a pre-1.0 crate I believe this is ok to do.

tcharding commented 7 months ago

Hey @RCasatta, the changelog entry for the 0.35.x series is missing. Do you want me to add that? (either as part of this or in a separate PR?)

RCasatta commented 7 months ago

utACK 2ff068fc0ed833fb4890782912e9192ce50b1de3

the changelog entry for the 0.35.x series is missing. Do you want me to add that?

Yes please, and sorry that I forgot.

either as part of this or in a separate PR?

As you prefer

tcharding commented 7 months ago

Done! I put a separate patch up the front for the missing changelog entries, this PR as a patch, and then a final "bump version number" patch for you to tag and release please.

Also the tag for v0.34.2 is missing. Looks like it should have been on commit c5b2184 Bump minor version.

apoelstra commented 7 months ago

utACK 76947495a36c8e836a693c26a9a434501f85d217

tcharding commented 7 months ago

Can we get this in please @RCasatta?

RCasatta commented 7 months ago

utACK 76947495a36c8e836a693c26a9a434501f85d217

Sorry for taking so long, I forgot

going to release 0.35.2 soon

tcharding commented 7 months ago

No sweat, thanks man!