Closed tcharding closed 7 months ago
Hey @RCasatta, the changelog entry for the 0.35.x
series is missing. Do you want me to add that? (either as part of this or in a separate PR?)
utACK 2ff068fc0ed833fb4890782912e9192ce50b1de3
the changelog entry for the 0.35.x series is missing. Do you want me to add that?
Yes please, and sorry that I forgot.
either as part of this or in a separate PR?
As you prefer
Done! I put a separate patch up the front for the missing changelog entries, this PR as a patch, and then a final "bump version number" patch for you to tag and release please.
Also the tag for v0.34.2
is missing. Looks like it should have been on commit c5b2184 Bump minor version
.
utACK 76947495a36c8e836a693c26a9a434501f85d217
Can we get this in please @RCasatta?
utACK 76947495a36c8e836a693c26a9a434501f85d217
Sorry for taking so long, I forgot
going to release 0.35.2
soon
No sweat, thanks man!
The last couple of releases of
bitcoincore-rpc
andbitcoin_hashes
have not required code changes here. This means we can use range dependencies. The benefit is that it makes the upgrade of other crates that usebitcoind
easier.Tested by pinning
hashes
with:And then pinning
bitcoincore-rpc
with all of the dependencies in the range and runningcargo check --all --all-features --all-targets
E.g (using
cc
as alias to the cargo check command above)Bump the crate patch version so we can release this change in a point release. Since this is a pre-1.0 crate I believe this is ok to do.