rust-bitcoin / rust-bitcoincore-rpc

Rust RPC client library for the Bitcoin Core JSON-RPC API.
340 stars 255 forks source link

Replace Signature with Message Signature #326

Closed masud-abdulkadir closed 6 months ago

masud-abdulkadir commented 10 months ago

When attempting to use verify_message() function, using Singature kept leading to InvalidSignature.

As such, we replaced Signature with MessageSignature from bitcoin::sign_message::MessageSignature.

We also noticed that there was a // TODO comment to test verify_message, so we also added a test function and it works with the new MessageSignature.

tcharding commented 6 months ago

Legendary, thanks!