rust-bitcoin / rust-bitcoincore-rpc

Rust RPC client library for the Bitcoin Core JSON-RPC API.

340 stars 255 forks source link

Implement a wrapper for `getblock` with verbosity value `2` #329

Open danielost opened 9 months ago

danielost commented 9 months ago

Changes

Add get_block_txs method that calls getblock with verbosity value 2
Add GetBlockTxResult struct to json
Utilize composition in GetBlockResult and GetBlockTxResult to get rid of duplicate fields

0xB10C commented 7 months ago

I was excited to see this when looking for a way to call getblock <hash> 2 to get the transaction fee of transactions it that block. However, the proposed implementation only deserializes the the hex field of each transaction. This is essentially the same as calling get_block_info() (if information about e.g. the next block or the number of confirmations are wanted) and get_block() for the raw transactions without any metadata.