Closed tcharding closed 6 months ago
All PRs in the todo list are ready to merge, lets get this release out!
Don't merge yet!
ok, looks good now. I did:
cargo publish -p bitcoincore-rpc-json --dry-run
and that succeedscargo publish -p bitcoincore-rpc --dry-run
fails because the bitcoincore-rpc-json
crate doesn't exist (yet).FTR the glitch above was we have to include the explicit version number of json
in client/Cargo.toml
when publishing - I previously removed it.
If you merge @apoelstra I'll tag and publish both crates.
Ok, merged. Go for it!
Damn, damn, damn, damn, damn - I've only got publish perms on bitcoincore-rpc
on on bitcoincore-rpc-json
.
CC @stevenroose
Further explanation: Steven gave me perms on one crate so I could publish but we forgot the other, bitcoincore-rpc
release requires a release of bitocincore-rpc-json
first.
In preparation for release add a changelog entry and bump the version number.
Patch 1 is a trivial cleanup of an old stale changelog file, no longer used.