search

rust-cli / anstyle

ANSI text styling
https://docs.rs/anstyle
Other
121 stars 20 forks source link

Make `utf8parse` dependency optional #219

Closed mondeja closed 1 month ago

mondeja commented 1 month ago

Makes the utf8parse dependency optional without introducing breaking changes. So I can use in my crate:

anstream = { version = "0.6", default-features = false, features = ["auto", "wincon"] }

and the utf8parse dependency will not be downloaded.

epage commented 1 month ago

While I've started responding, the core of this really should be discussed in an issue per our contributing guidelines

Already have an idea? It might be good to first create an issue to propose it so we can make sure we are aligned and lower the risk of having to re-work some of it and the discouragement that goes along with that.

I'm going to go ahead and close in favor of an issue. What I would recommend focusing the issue on is why this is a problem. As-is, I'm not convinced this is worth doing.