rust-db / refinery

Powerful SQL migration toolkit for Rust.
MIT License
1.35k stars 126 forks source link

fix missleading CLI arguments #336

Closed solc42 closed 5 months ago

solc42 commented 6 months ago

It looks very strange, but CLI arguments -d/-m help descriptions are inverted vs actual behaviour.

Those flags are passed as is to corresponding library methods

https://github.com/rust-db/refinery/blob/005df131468bd6e768e3b95dc3f514f9f476efe1/refinery_core/src/runner.rs#L268-L271

and

https://github.com/rust-db/refinery/blob/005df131468bd6e768e3b95dc3f514f9f476efe1/refinery_core/src/runner.rs#L278-L282

Mb by design the default behaviour expected to be fail fast, but nowadays it is not. So keeping the same behaviour, let's correct the CLI help msg =)