Closed Dirbaio closed 1 year ago
updated most of Embassy here, no issues to report. https://github.com/embassy-rs/embassy/pull/1752
One downside is this breaks if you enable both defmt-03 and defmt-04.
because the generated macros refer to defmt
by path i don't think this can ever be possible* ? but seems like an okay compromise to me.
* without defmt macros internally using versioned paths, or maybe using some macro trickery to get a $1
from the macro invocation
embedded-io
, embedded-io-async
, embedded-io-adapters
v0.5.0 released :rocket:
also, added HAL team as owners.
@ryankurte: because the generated macros refer to defmt by path i don't think this can ever be possible* ?
yeah, I don't think it's posisble either, without changes to defmt.
following discussions in #450, the Cargo feature is named
defmt-03
instead ofdefmt
. This leaves the door open to add support for newer versions of defmt in the future without breaking changes, naming the featuresdefmt-04
ordefmt-1
, like this:One downside is this breaks if you enable both
defmt-03
anddefmt-04
. This is annoying, because in theory it should be possible to impl both the 0.3 and 0.4Format
on the same struct. However in practice it's unlikely that a user wants this sincedefmt
doesn't allow mixing major versions in the same binary anyway.