search

rust-fuzz / targets

🎯 A collection of fuzzing targets written in Rust.
Creative Commons Zero v1.0 Universal
104 stars 21 forks source link

Replace unmaintained flac crate by claxon #101

Closed PaulGrandperrin closed 6 years ago

PaulGrandperrin commented 6 years ago

https://github.com/ruuda/claxon

killercup commented 6 years ago

Not sure how this is actionable:

What you, or @ruuda, might want to do is contact the author of flac to see if they are willing to give you the crate name, e.g., so you could publish an 0.6 version that uses claxon internally.

killercup commented 6 years ago

Also, I just remembered there is https://github.com/rustaudio which is a github orga all about audio crates, which @frewsxcv is also a member of (seriously, Corey, what don't you do).

If you are concerned with unifying the efforts for a pure-Rust flac implementation, maybe it makes sense to move the flac crate over to this orga and try to maintain it as a community. claxon seems to be focussed on being a flac decoder while the flac crate has a checklist that includes "[ ] encoder" so from my outside perspective it makes sense to work towards a flac 0.6 with a decoder using claxon and an encoder using a binding to libflac.

ruuda commented 6 years ago

I fuzz Claxon regularly, and I fuzz it as part of the release process. (Thanks rust-fuzz and especially the authors of cargo-fuzz!) I have no plans to build an encoder at this point.

I do not think there is a problem with the current state of affairs of crates, and I do not think anything needs to be done there.

PaulGrandperrin commented 6 years ago

Oh I didn't really look into claxon. I was generalizing https://github.com/rust-fuzz/targets/ to multiple fuzzers (https://github.com/PaulGrandperrin/fuzz-targets-rs) and I constated that flac was unmaintained so I looked for another one.

I hope that someday cargo-fuzz will be able to use any fuzzer as a backend.

Also the advantage of having all fuzing targets in one repository is to eventally do something like https://github.com/google/oss-fuzz.

killercup commented 6 years ago

I'll close this per https://github.com/rust-fuzz/targets/issues/101#issuecomment-382902592 but it might make sense to add claxon targets to this repo while we work in generalizing cargo-fuzz to more backends.