rust-hermes / rusty_hermes

Rust bindings for the Hermes JavaScript engine
https://rust-hermes.github.io/rusty_hermes/
MIT License
56 stars 1 forks source link

statically linked hermes #1

Open littledivy opened 4 months ago

littledivy commented 4 months ago

it would be nice to statically link to libhermesabi.a.

building with -DHERMES_STATIC_LINK builds the archive for me but didn't link (bunch of undefined symbol errors).

mishushakov commented 4 months ago

Agreed. I'm assuming this is a problem with Hermes? Could you open issue in the hermes repo then?

mishushakov commented 4 months ago

I'm getting this atm.

  icu dir: /usr/lib/x86_64-linux-gnu
  /usr/bin/ld: attempted static link of dynamic object `/usr/lib/x86_64-linux-gnu/libicuuc.so'
  collect2: error: ld returned 1 exit status
  make[3]: *** [tools/hermesc/CMakeFiles/hermesc.dir/build.make:115: bin/hermesc] Error 1
  make[2]: *** [CMakeFiles/Makefile2:3593: tools/hermesc/CMakeFiles/hermesc.dir/all] Error 2
  make[1]: *** [CMakeFiles/Makefile2:3445: API/hermes_abi/CMakeFiles/hermesabi.dir/rule] Error 2
  make: *** [Makefile:788: hermesabi] Error 2
  thread 'main' panicked at /home/codespace/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 2