search

rust-lang-ja / ac-library-rs

ac-library-rs is a rust port of AtCoder Library (ACL).
Creative Commons Zero v1.0 Universal
225 stars 27 forks source link

Rename the package name and/or the crate name #47

Closed qryxip closed 1 year ago

qryxip commented 4 years ago

In Rust, it is common to set a repository name to foo-rs and to set a package.name to foo.

In actual, cargo new strip the "-rs" suffixes until recently.

$ cargo +1.15.1 new foo-rs --lib
note: package will be named `foo`; use --name to override
     Created library `foo-rs` project

Why don't we rename the package name to ac-library or ac_library?

qryxip commented 4 years ago

Or, or rather and, We can rename the lib.name to "atcoder" or something.

[lib]
name = "atcoder"

Then we can write in this way in examples and integration-tests (if we will write them) .

use atcoder::Dsu;
koba-e964 commented 2 years ago

Agreed on ac_library. I'm afraid that atcoder may give a wrong impression that this crate is officially maintained by AtCoder, which is not quite right.

TonalidadeHidrica commented 1 year ago

I agree with this suggestion. Do you think we shuold/can change this until 2023/04/07 (deadline of the language update?)

qryxip commented 1 year ago

I think we should do. Or rather, this is the last chance.

qryxip commented 1 year ago

I came up with another name. acl.

use acl::FenwickTree;

Repository name: ac-library-rs package.name: ac-library-rs lib.name (a.k.a. "crate_name"): ac_library_rs → acl

TonalidadeHidrica commented 1 year ago

Which name is used in crates.io ? package.name or lib.name? Also I'm not so much in favor of such a short name because it is not very descriptive.

qryxip commented 1 year ago

package.name.

Example: The default crate_name of xml-rs is xml.

qryxip commented 1 year ago

@manta1130 @kenkoooo @tttanikawa @hotman78 Mentioning to you as contributors. Would you give us your thoughts?

We have the following choices.

  1. As is

    package.name: ac-library-rs lib.name: ac_library_rs

  2. ac-library/ac_library

    package.name: ac-library lib.name: ac_library

  3. ac-library-rs/ac_library

    package.name: ac-library-rs lib.name: ac_library

  4. atcoder (same as the original ACL)

    package.name: ac-library-rs lib.name: atcoder

  5. acl

    package.name: ac-library-rs lib.name: acl

qryxip commented 1 year ago

I created two PRs for 5. and 3.

@mizar Could you choose one and merge it? As I mentioned, today is the last chance.