search

rust-lang / cargo-bisect-rustc

Bisects rustc, either nightlies or CI artifacts
https://rust-lang.github.io/cargo-bisect-rustc/
Apache License 2.0
177 stars 55 forks source link

Default to `--access github` #307

Closed Noratrieb closed 8 months ago

Noratrieb commented 8 months ago

I've been using cargo-bisect-rustc for a while now, and --access github has never caused any problems. Maybe it can run into ratelimiting in extreme cases, but the user should then just use git.

Meanwhile, git is a very confusing default as it will suddelny just start cloning the repo unless you were very careful when installing.

ehuss commented 8 months ago

I have not used the github access method much, but I'm game to try. It certainly will be a better default experience as long as it is not rate limited. @oli-obk what do you think?

Noratrieb commented 8 months ago

I think it is rate limited, but I've never hit the limit in practice when doing one-off bisections (or even two or three).

Nemo157 commented 8 months ago

The unauthenticated rate limit is 60 requests/hour/IP, which should be more than enough for bisecting, outside heavily NATted connections (I would assume it only does one request per run?).