This fixes an issue where if a SHA commit is given that isn't a bors commit, it would result in a confusing panic message about two sha's not being equal.
The LocalGit backend handled this, but the GitHub backend did not. The solution here is to lift the check up to a higher level. It will fetch the start and end commits, and check the author of them.
This required a few code changes, since the committer info wasn't exposed. In summary:
Added the committer field to the Commit object. Then added the necessary code to add that info.
In bisect_ci_via, check the start/end are by bors before querying for the range of commits.
A few minor cleanups:
Added BORS_AUTHOR const.
Changed GithubCommit's author and committer to be Option to more correctly follow GitHub's API (since they can be nil).
This fixes an issue where if a SHA commit is given that isn't a bors commit, it would result in a confusing panic message about two sha's not being equal.
The LocalGit backend handled this, but the GitHub backend did not. The solution here is to lift the check up to a higher level. It will fetch the start and end commits, and check the author of them.
This required a few code changes, since the committer info wasn't exposed. In summary:
committerfield to theCommitobject. Then added the necessary code to add that info.bisect_ci_via, check the start/end are by bors before querying for the range of commits.GithubCommit'sauthorandcommitterto beOptionto more correctly follow GitHub's API (since they can be nil).