LowerExp and UpperExp format traits implementations are missing from the NonZero integer types. All other (Binary, *Hex, Octal, etc) have been implemented, so it looks like an oversight, especially since the integer primitives themselves do implement LowerExp and UpperExp.
Motivating examples or use cases
UpperExp example changed to use NonZeroU32
fn main() {
let x = core::num::NonZeroU32::new(42).unwrap(); // 42 is '4.2E1' in scientific notation
assert_eq!(format!("{x:E}"), "4.2E1");
}
Solution sketch
Implement LowerExp and UpperExp. It probably only involves adding impl_nonzero_fmt!(LowerExp) and impl_nonzero_fmt!(UpperExp) to the list of format impls
Alternatives
Use .get() like a pleb, which then needs to be passed as an argument since you cannot call functions from format! and friends.
Links and related work
N/A
What happens now?
This issue contains an API change proposal (or ACP) and is part of the libs-api team feature lifecycle. Once this issue is filed, the libs-api team will review open proposals as capability becomes available. Current response times do not have a clear estimate, but may be up to several months.
Possible responses
The libs team may respond in various different ways. First, the team will consider the problem (this doesn't require any concrete solution or alternatives to have been proposed):
We think this problem seems worth solving, and the standard library might be the right place to solve it.
We think that this probably doesn't belong in the standard library.
Second, if there's a concrete solution:
We think this specific solution looks roughly right, approved, you or someone else should implement this. (Further review will still happen on the subsequent implementation PR.)
We're not sure this is the right solution, and the alternatives or other materials don't give us enough information to be sure about that. Here are some questions we have that aren't answered, or rough ideas about alternatives we'd want to see discussed.
Proposal
Problem statement
LowerExp
andUpperExp
format traits implementations are missing from theNonZero
integer types. All other (Binary
,*Hex
,Octal
, etc) have been implemented, so it looks like an oversight, especially since the integer primitives themselves do implementLowerExp
andUpperExp
.Motivating examples or use cases
UpperExp
example changed to useNonZeroU32
Solution sketch
Implement
LowerExp
andUpperExp
. It probably only involves addingimpl_nonzero_fmt!(LowerExp)
andimpl_nonzero_fmt!(UpperExp)
to the list of format implsAlternatives
Use
.get()
like a pleb, which then needs to be passed as an argument since you cannot call functions fromformat!
and friends.Links and related work
N/A
What happens now?
This issue contains an API change proposal (or ACP) and is part of the libs-api team feature lifecycle. Once this issue is filed, the libs-api team will review open proposals as capability becomes available. Current response times do not have a clear estimate, but may be up to several months.
Possible responses
The libs team may respond in various different ways. First, the team will consider the problem (this doesn't require any concrete solution or alternatives to have been proposed):
Second, if there's a concrete solution: