search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.66k stars 349 forks source link

Clear `eval_libc` errors from unix shims #3984

Closed noahmbright closed 1 month ago

noahmbright commented 1 month ago

Each instance of eval_libc("E is scrubbed out. Currently, this has the idealistic function calls, but this won't compile yet. Marking as a draft and making comments with the representative compilation errors. Whether we want to hold off on making these erring changes or address the root problem now is up to the reviewers.

See comments for the issues concretely, but it seems like everything stems from differences between the return types of this.eval_libc and LibcError.

RalfJung commented 1 month ago

marked this pull request as ready for review

Note that this does not trigger a notification, so it is easy to be missed. Please do this instead: @rustbot ready

RalfJung commented 1 month ago

@rustbot author

noahmbright commented 1 month ago

Reverted that change in sync.rs and rebased a merge conflict, hence the force push. @rustbot ready

RalfJung commented 1 month ago

Thanks! Please squash this into a single commit. @rustbot author

noahmbright commented 1 month ago

Done - again thanks for your patience and willingness to help. I was definitely too excited about mindlessly changing every eval_libc I could find. This was a good lesson for me. @rustbot ready