search

rust-lang / rls

Repository for the Rust Language Server (aka RLS)
Other
3.53k stars 257 forks source link

Expose more functions for processing analysis files #1743

Closed wcalandro closed 2 years ago

wcalandro commented 3 years ago

Kythe's Rust indexer currently makes use of the read_analysis_from_files function, but for our use case we'd prefer to have the ability to load an analysis from a specific path and, more importantly, the ability to deserialize an analysis directly from string contents.

wcalandro commented 2 years ago

@Xanewok Could you give some feedback on this PR? If you don't believe this is a good change or believe that it should be implemented differently I can definitely refactor the PR.

Xanewok commented 2 years ago

Sorry for the delay. I can definitely see how it's useful; it also looks like the deserialization code might use some refreshing but if that's helpful to you, I won't block it and will merge this now. Thanks for the PR!

@bors r+

bors commented 2 years ago

:pushpin: Commit 5276b29ce8db2a5ffa7c0caca6916fa00bfb242c has been approved by Xanewok

bors commented 2 years ago

:hourglass: Testing commit 5276b29ce8db2a5ffa7c0caca6916fa00bfb242c with merge abcfc02a197eb11d05ec68382f7a76cf622afd95...

bors commented 2 years ago

:sunny: Test successful - checks-actions Approved by: Xanewok Pushing abcfc02a197eb11d05ec68382f7a76cf622afd95 to master...

wcalandro commented 2 years ago

Thanks for merging! Would it also be possible to push 0.18.2 to crates.io?