search

rust-lang / rls

Repository for the Rust Language Server (aka RLS)
Other
3.52k stars 257 forks source link

Adapt to clippy API changes. #1759

Closed hkratz closed 2 years ago

hkratz commented 2 years ago

Against the rustup branch.

Part of the fix for https://github.com/rust-lang/rust/issues/91543

flip1995 commented 2 years ago

Those changes are already included in RLS master, but not synced to the Rust repo, because for that, Racer would have to be fixed first. See https://github.com/rust-lang/rls/pull/1753

hkratz commented 2 years ago

Ah, thanks!

Is the Racer fix really needed immediately if a dummy thread_local_const_init feature gate is reintroduced? That will make rustc-ap-rustc_span build again.

flip1995 commented 2 years ago

I think the thread_local_const_init fixes the feature gate thing. But I'm not sure if the Clippy issue can be fixed without a sync. (But let's figure this out in the Zulip thread)