rust-lang / rust-forge

Information useful to people contributing to Rust
https://forge.rust-lang.org/
Apache License 2.0
466 stars 175 forks source link

Add Archive of Rust Stable Standalone Installers #733

Closed yerke closed 6 months ago

yerke commented 8 months ago

Closes https://github.com/rust-lang/rust-forge/issues/676

This PR adds a new page "Archive of Rust Stable Standalone Installers" that contains a list of tables of previous stable Rust version standalone installers.

Currently it works for all versions > 1.8. Versions <= 1.7 do not have v2 toml manifests. See Zulip for details.

@shepmaster @ojeda Is this what you had in mind?

Screenshots:

Screenshot 2024-03-22 at 3 33 08 AM Screenshot 2024-03-22 at 3 33 41 AM
rustbot commented 8 months ago

r? @ehuss

rustbot has assigned @ehuss. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

yerke commented 8 months ago

r? @shepmaster

yerke commented 7 months ago

r? @ehuss

yerke commented 7 months ago

@ehuss thanks a lot for taking a look. I addressed your feedback.

ojeda commented 7 months ago

@shepmaster @ojeda Is this what you had in mind?

Yeah, thanks a lot!

It could be nice to have a matrix instead (but that makes it complex, i.e. empty cases would need to be handled, plus it may be not great scrolling horizontally, so it could require breaking the table in several anyway), or a selector, or at least a way to jump quickly to the right version.

But I would not worry about any of that -- even if it is just a dump of links, it is useful :)

ehuss commented 7 months ago

I am not on the infra or release teams, so I'm not sure I am the appropriate person to be approving things on their behalf. Perhaps @Mark-Simulacrum would give the green light. I'm fine with the implementation barring https://github.com/rust-lang/rust-forge/pull/733#discussion_r1559834763 getting resolved.

yerke commented 7 months ago

@Mark-Simulacrum Do you mind taking another look when you get a chance? Thanks.

Kobzol commented 6 months ago

Could you remove the merge commits please?

yerke commented 6 months ago

@Kobzol done!