Closed jonathanpallant closed 2 days ago
r? @kobzol
rustbot has assigned @kobzol. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
r? @Kobzol
Could not assign reviewer from: Kobzol
.
User(s) Kobzol
are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r?
to specify someone else to assign.
2024-11-25T14:54:30.6117409Z gathering license information from REUSE (this might take a minute...)
2024-11-25T14:56:14.6781427Z finished gathering the license information from REUSE in 104.07s
2024-11-25T14:56:19.6861238Z loading existing license information
2024-11-25T14:56:19.6862080Z license information matches
:)
Thank you, this was a pleasure to review. It's almost as if you're not doing this for the first time :laughing:
@bors r+
This PR adds
license-metadata.json
to the root of the git repo, and changesmingw-check
to check that the file is still up-to-date.By committing this file, we remove the need for developers to a) have reuse installed or b) run an expensive ~90 second analysis of the files on disk when they want generate the COPYRIGHT.html files which depend on this license metadata.
The file will need updating whenever
REUSE.toml
changes, or when git submodules are added, or when git submodules change their license information (as detected by REUSE).You can now run:
./x run collect-license-metadata
to update the./license-metadata.json
file./x test collect-license-metadata
to test the./license-metadata.json
file for correctnessThe comparison is done with two
serde_json::Value
objects, so the map objects they contain should ignore differences in ordering.