rust-lang / rust

Empowering everyone to build reliable and efficient software.
https://www.rust-lang.org
Other
99.01k stars 12.79k forks source link

Commit license-metadata.json to git and check it's correct in CI #133453

Closed jonathanpallant closed 2 days ago

jonathanpallant commented 4 days ago

This PR adds license-metadata.json to the root of the git repo, and changes mingw-check to check that the file is still up-to-date.

By committing this file, we remove the need for developers to a) have reuse installed or b) run an expensive ~90 second analysis of the files on disk when they want generate the COPYRIGHT.html files which depend on this license metadata.

The file will need updating whenever REUSE.toml changes, or when git submodules are added, or when git submodules change their license information (as detected by REUSE).

You can now run:

The comparison is done with two serde_json::Value objects, so the map objects they contain should ignore differences in ordering.

rustbot commented 4 days ago

r? @kobzol

rustbot has assigned @kobzol. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jonathanpallant commented 4 days ago

r? @Kobzol

rustbot commented 4 days ago

Could not assign reviewer from: Kobzol. User(s) Kobzol are either the PR author, already assigned, or on vacation, and there are no other candidates. Use r? to specify someone else to assign.

jonathanpallant commented 4 days ago
2024-11-25T14:54:30.6117409Z gathering license information from REUSE (this might take a minute...)
2024-11-25T14:56:14.6781427Z finished gathering the license information from REUSE in 104.07s
2024-11-25T14:56:19.6861238Z loading existing license information
2024-11-25T14:56:19.6862080Z license information matches

:)

Kobzol commented 3 days ago

Thank you, this was a pleasure to review. It's almost as if you're not doing this for the first time :laughing:

@bors r+

bors commented 3 days ago

:pushpin: Commit db71194416700d2c1365ae1ee7f882aa3a055a67 has been approved by Kobzol

It is now in the queue for this repository.