search

rust-lang / triagebot

Automation/tooling for Rust spaces
https://triage.rust-lang.org
Apache License 2.0
176 stars 77 forks source link

"review-submitted" automation does not work #1859

Open RalfJung opened 5 days ago

RalfJung commented 5 days ago

We have added this to our triagebot.toml in Miri in the hopes of getting automatic labels when submitting a "changes requested" review:

[review-submitted]
# This label is added when a "request changes" review is submitted.
reviewed_label = "S-waiting-on-author"
# These labels are removed when a "request changes" review is submitted.
review_labels = ["S-waiting-on-review"]

However, this does not seem to work -- I submitted such a review in https://github.com/rust-lang/miri/pull/4054, and the labels were not updated.

We copied the config here from the Rust repo. This slightly different than what the documentation says:

[review-submitted]
# These labels are removed when a review is submitted.
review_labels = ["S-waiting-on-review"]
# This label is added when a review is submitted.
reviewed_label = ["S-waiting-on-author"]

In the docs, reviewed_label is still a list, even though the name is singular -- that's confusing. Not sure if the docs are right or the rustc repo is right?

RalfJung commented 5 days ago

Looking at https://github.com/rust-lang/triagebot/blob/d7d4babe564e264ea4824bba1ba55a8088d8a9fd/src/config.rs#L305 it seems like the docs are wrong here. So the Miri config should be right -- but it doesn't work.

Cc @oli-obk