search

rust-num / num-integer

Integer trait and functions for Rust
Apache License 2.0
180 stars 48 forks source link

Add invmod API to Integer trait #36

Closed unseddd closed 3 years ago

unseddd commented 3 years ago

This will need some unit tests, and testable doc-examples would be nice.

No problem, can update with unit tests, and try my hand at some doc-examples :)

This also overlaps with #10 -- if @vks responds I would give preference to their PR for coming first.

Didn't mean to step on any toes. Will definitely close, and give preference to @vks over this PR. Just wasn't sure if #10 was still relevant, since similar code exists in num-integer already (what's used by this PR).

unseddd commented 3 years ago

@cuviper I added the requested changes, let me know what you think. Will squash the fixup, if you approve.

vks commented 3 years ago

I will update my PR this week.

On Mon, Jan 18, 2021, 21:05 Nym Seddon notifications@github.com wrote:

@cuviper https://github.com/cuviper I added the requested changes, let me know what you think. Will squash the fixup, if you approve.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rust-num/num-integer/pull/36#issuecomment-762447756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIFNF77J5Q7KWFNUICXHTS2SH63ANCNFSM4VM42JAA .

unseddd commented 3 years ago

Closing in favor of an updated #10