rust-num / num-traits

Numeric traits for generic mathematics in Rust
Apache License 2.0
694 stars 131 forks source link

Bugfix for text codeblock in documentation. #286

Closed robamu closed 11 months ago

robamu commented 11 months ago

Fixes https://github.com/rust-num/num-traits/issues/285 . From what I have seen, the local output generated with cargo +nightly doc --open (rustc v1.74.0 nightly 203c57dbe) does not look differently than the most current one found here: https://docs.rs/num-traits/latest/num_traits/identities/trait.One.html

Propably related to https://github.com/rust-lang/rust/pull/110800 ? If it is, then the issue might be fixed soon and this PR should be ignored..

cuviper commented 11 months ago

Looks like rust-lang/rust#115914 just relaxed that to a warning, but that's still annoying. Since your change has the right formatting without warning or error, even on older Rust, it's a reasonable change anyway. Thanks!

bors r+

bors[bot] commented 11 months ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

kangalio commented 11 months ago

Could a new patch release with this PR be pushed out soon? This presumably breaks CI workflow in many crates

OliverKillane commented 11 months ago

@robamu could this be released as num-traits-0.2.17?

robamu commented 11 months ago

I am not a maintainer of this crate. @cuviper is probably the better person to ask.

cuviper commented 11 months ago

Published via #289.