rust-vmm / community

rust-vmm community content
499 stars 28 forks source link

Signed-off-by Requirement: What do you sign off on? #134

Closed blitz closed 1 year ago

blitz commented 2 years ago

Contributions require commits to have a Signed-off-by: line, but I could find no documentation on what this specifically means in the rust-vmm context.

To quote the git commit man page:

       -s, --signoff, --no-signoff
           Add a Signed-off-by trailer by the committer at the end of the commit log message. The meaning of a
           signoff depends on the project to which you’re committing. For example, it may certify that the committer
           has the rights to submit the work under the project’s license or agrees to some contributor
           representation, such as a Developer Certificate of Origin. (See http://developercertificate.org for the
           one used by the Linux kernel and Git projects.) Consult the documentation or leadership of the project to
           which you’re contributing to understand how the signoffs are used in that project.

So what do we sign off when we contribute to rust-vmm? This is especially important for contributors from companies, because they may or may not be able to contribute depending on what they are asked to agree to.

blitz commented 1 year ago

Any update here?

bonzini commented 1 year ago

Hi, sorry no one has noticed this so far.

Just like for Linux, the Signed-off-by for rust-vmm certifies that the developer has read and agrees to the Developer Certificate of Origin:

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.