rust-vmm / vhost-device

'vhost-user' device backends workspace
Apache License 2.0
68 stars 48 forks source link

sound/pipewire: remove duplicate increment #638

Closed MatiasVara closed 8 months ago

MatiasVara commented 8 months ago

Summary of the PR

For capturing, pipewire backend is incrementing the position in the buffer, however, this is already done by write_input() thus resulting in incrementing two times the position. This commit removes the incrementation that happens in pipewire.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

stefano-garzarella commented 8 months ago

CI failure is unrelated. I'll open another PR to update the vhost-device-vsock dependency

MatiasVara commented 8 months ago

After this change in some places we use buf_pos, in others buffer.pos, I would try to unify it (maybe removing buf_pos at all)

I just figured out. I removed everywhere.