Closed TimosAmpel closed 1 week ago
I think the two commits can be squashed, there's no reason to update Cargo.lock separately is there?
Generally LGTM!
Thanks for your review @epilys. Yes indeed I agree, I just merged everything in one commit. SInce the last push I have also modified the coverage value under staging so the CI succeeds after moving vhost-device-can, let me know if that's ok.
@TimosAmpel looks good. you can drop the Update licenses' symlinks for vhost-device-console
commit since it's part of https://github.com/rust-vmm/vhost-device/pull/758
@TimosAmpel fyi you can (and probably should since this is your device) leave reviews in https://github.com/rust-vmm/vhost-device/pull/758 and other PRs in general even if you're not a maintainer. They just don't count towards the "two approving reviews required" limit.
@TimosAmpel fyi you can (and probably should since this is your device) leave reviews in #758 and other PRs in general even if you're not a maintainer. They just don't count towards the "two approving reviews required" limit.
@epilys Thanks for pointing that out. Yes, I will review the changes done the next days
Summary of the PR
This PR updates the socketcan-rs dependency of vhost-device-can device and moves it on the main workspace.
Specifically by updating the socketcan-rs dependency to "v3.3.1" this PR solve the following issues noted in the Cargo.toml of the vhost-device-can:
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.