search

rusticata / pcap-parser

PCAP/PCAPNG file format parser written in pure Rust. Fast, zero-copy, safe.
Other
103 stars 24 forks source link

Replace Circular with Oval and add Miri tests #38

Open Posnet opened 4 months ago

Posnet commented 4 months ago

Oval is a nicer, maintained fork of Circular, that removes the unsafe and unsound code (it replaces them with stdlib features that didn't exist at the time of Circular's writing such as copy_within, so it should generate the same code). Replacing Ciruclar with Oval means we can now add Miri tests to check for undefined/unsound behavior in unsafe rust (even though there isn't in this crate).

Posnet commented 4 months ago

Also, apologies with the noise of the other pull request I opened and closed, I realized I had the wrong git config for those commits, I had my gmail set instead of my git one.