search

rustsec / audit-check

🛡️ GitHub Action for security audits
MIT License
49 stars 8 forks source link

Warning: Unknown warning kind unsound found, please, file a bug #8

Closed FabianLars closed 1 year ago

FabianLars commented 1 year ago

First of all, thanks for taking over the action ❤️

We started seeing this warning in CI and i guess it's caused by https://github.com/rustsec/rustsec/pull/819 ? I tried to fix it myself but i have no knowledge about cargo-audit nor the action so that didn't end well 😅

Thanks again :)

pinkforest commented 1 year ago

Hey thanks! - Could we try there with rustsec/audit-check@main now as I added the correct informational types ?

I'll push out a new release for @v1.4.0 but would like to confirm here as well please

FabianLars commented 1 year ago

Yep seems to work, not seeing that warning anymore: https://github.com/tauri-apps/plugins-workspace/actions/runs/4605104520/jobs/8136735767 Thank you!

pinkforest commented 1 year ago

Great - thanks - I've released v1.4.0 which can be used via rustsec/audit-check@v1.4.0

pinkforest commented 1 year ago

@FabianLars The behaviour when the workflow is triggered via cron is different so I had to fix that as well

I've corrected the scheduled workflow in v1.4.1 and now it should raise issues for unsound advisories as well.

This is now reflected in rustsec/audit-check@v1.4.1

FabianLars commented 1 year ago

Hello again. I don't know if i'm missing something obvious here, but i think that either i was wrong when i tested 1.4.0, or 1.4.1 re-introduced the issue since i'm seeing the warning log in PR checks again: https://github.com/tauri-apps/plugins-workspace/actions/runs/4721568327/jobs/8374994844?pr=309#step:3:14 (using rustsec/audit-check@v1) Edit: Same for scheduled runs: https://github.com/tauri-apps/plugins-workspace/actions/runs/4716122883