define RT_FLASH_ENABLED RT_FLASH_ENABLED + (APP_GATT_ENABLED))

should it be

define RT_FLASH_ENABLED RT_FLASH_ENABLED | APP_GATT_ENABLED

+++++++++++++

2) application_mode_longlife.h:

define RT_FLASH_ENABLED (o)

notice letter o , should it be

define RT_FLASH_ENABLED false

ojousima commented 1 year ago

Are these correct??

OR might be more clear on intent and would protect against accidental use of negative configuration values.
Yes, fixed in 1375ee5

DG12 commented 1 year ago

While you're at it (or would you rather have me make a PullRequest after you're done?) in app_config.h, could you remove SHTC comment from nRF52 mode.

203: #ifndef APP_SENSOR_NRF52_MODE 204: # define APP_SENSOR_NRF52_MODE RD_SENSOR_CFG_CONTINUOUS //!< SHTC runs in single-shot mode internally, update data automatically on fetch. +++++++++++++++++++++++++

And add to the top and remove similar from lines 27...

/**
 * @file application_config/app_config.h
 * @author Otso Jousimaa <otso@ojousima.net>
 * @date 2020-04-16
 * @brief Master configuration base
 * @detail Variables which can be adjusted by application_mode_xxxxx.h are preceded by  #ifdef
 * 
 *  Do not make customizations here. Edit application_mode_xxxx.h
 *
 * @copyright Ruuvi Innovations Ltd, license BSD-3-Clause.
 */