Support Sensirion SEN55

[reviewpad[bot]]

Thank you @TheSomeMan for this first contribution!

[reviewpad[bot]]

Reviewpad Report

:bangbang: Errors

• Unconventional commit detected: 'app_heartbeat: disable watchdog feeding when RUUVI_RUN_TESTS is defined' (980171ecf629620f5f1aefa98635c328f4969de5)
• Unconventional commit detected: 'Initial support for SEN55, build in SES' (d30a47dfad49be96e5c602c563544ed8a3a64a7e)
• Unconventional commit detected: 'Temporary disable integration_tests_run' (f8fc991b84a025f5cf827ac641f5be0f825bee32)
• Unconventional commit detected: 'Update makefiles (not finished yet)' (3890bfd700227704a4d129bee58481fedf80f6f4)
• Unconventional commit detected: 'ruuvi.firmware.c.emProject: Remove SEGGER_RTT_Syscalls_SES.c from the projects to fix compilation error "__vfprintf.h: No such file or directory"' (c7c797a14e00b5c202f70dd8db31ffb552b46f25)
• Unconventional commit detected: 'ruuvi.firmware.c.emProject: Exclude ruuvi_interface_sen55.* from ruuvi.drivers.c/src/interfaces/environmental for all projects' (da345db06cc0590c1a47608d4b155db49a8411ce)
• Unconventional commit detected: 'ruuvi.firmware.c.emProject: integrate ruuvi_airq project' (10a89e762f417535fd89f9c0d8428699b490a846)
• Unconventional commit detected: 'Implement support of Ruuvi data format 6 and send air quality measurements' (377ecb9e09f0e30ec6f1cf087adc0ea71cc6b522)
• Unconventional commit detected: 'Add SCD41 support for ruuvi_airq' (8b0e6b35220df3c4ced496f6dbca6715549ef7ce)
• Unconventional commit detected: 'Remove dependency on PVS-Studio' (d7bde804b9b3ab60462876a7d2503f37e59812ff)
• Unconventional commit detected: 'Update makefile to build project with SEN55 and SCD41, refactoring' (1a37dca9fcdfd2c944014ec45088acc366793916)
• Unconventional commit detected: 'Update ruuvi.endpoints.c to the master branch' (3d47cf782dab6ca2bfddd8bec10de52786128b53)
• Unconventional commit detected: 'Fix formatting in app_dataformats.c' (139bcdf853a671788a5824284856f5656e19d83b)
• Unconventional commit detected: 'Update ruuvi.drivers.c: SCD41: temperature and humidity are mixed up' (343e7695ff0c7c979e6732848d19f5641fe36f50)
• Unconventional commit detected: 'Format code in app_sensor.c' (89974481752707d669d9eb81935ed03b5c4d28b1)
• Unconventional commit detected: 'Swap sections for ruuvitag_b and ruuvi_airq in Makefile to fix issues related to IDE' (2491b64622687cd6b40fb4e1c8c012ec956d032f)
• Unconventional commit detected: 'Update ruuvi.edpoints.c - fix incorrect invalid temperature decoding' (da9c3dce93895b77ae985b9f88aba42f5a3f6a3a)
• Unconventional title detected: 'Support Sensirion SEN55' illegal 'u' character in commit message type: col=01

:warning: Warnings

• Please link an issue to the pull request

[ojousima]

Overall looks good, the SES project is probably easiest to merge with the main project file. Different projects inherit global settings and keeping separate files in sync would be a lot of effort. Ping me if it is not clear how to add the sensor to app_sensor.c

[TheSomeMan]

Overall looks good, the SES project is probably easiest to merge with the main project file. Different projects inherit global settings and keeping separate files in sync would be a lot of effort. Ping me if it is not clear how to add the sensor to app_sensor.c

This is what I initially tried to do, but I ran into some problems and decided to temporarily make a separate project to speed up testing. Unfortunately, after adding "embedded-i2c-sen5x" there were some conflicts.

In ruuvi.drivers.c/embedded-sht/embedded-common folder there are files:

• sensirion_common.c
• sensirion_common.h
• sensirion_i2c.h

And in the newly added ruuvi.drivers.c/embedded-i2c-sen5x folder:

• sensirion_common.c
• sensirion_common.h
• sensirion_i2c.h

In the SES solution, the preprocessor configuration is defined on the top level and it's shared between all projects. I will try to override options for the new project.

Also, files from "ruuvi.drivers.c/src/interfaces" are added to the projects by wildcards and it causes conflicts between "environmental/ruuvi_interface_shtcx.c" and "environmental/ruuvi_interface_sen55.c" because they are using different sensirion_i2c.h

[ojousima]

Closing as stale