ruuvi / ruuvi.firmware.c

Ruuvi Firmware version 3. Built on top of Nordic SDK 15, uses both Ruuvi and external repositories as submodules. In Beta, no breaking changes are intended but may be done if absolutely necessary
BSD 3-Clause "New" or "Revised" License
54 stars 37 forks source link

Remove unused function/variable #358

Closed ojousima closed 5 months ago

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ojousima commented 5 months ago

Is PVS Studio no longer to be used?

Yes, PVS Studio changed their licensing for open source and we do not match their terms anymore.

ojousima commented 5 months ago

Why didn't you like it?

There is no practical way for users to read it out without devkit, and it's hard even with devkit. Since it's not used in production it is bit unnecessary, and the way nRF filesystem works clutters up the flash page. Data is not replaced, it's written as "not valid" and new element is added