search

ruven / iipsrv

iipsrv is an advanced high-performance feature-rich image server for web-based streamed viewing and zooming of ultra high-resolution images.
https://iipimage.sourceforge.io
GNU General Public License v3.0
293 stars 115 forks source link

Compile-warning #212

Closed andreasdijkman closed 3 years ago

andreasdijkman commented 3 years ago

When I compile the latest version, 7d0a28223a1abdec75e7b16f40b828eff00abe39, it spit's out some warnings:

IIIF.cc: In member function 'virtual void IIIF::run(Session*, const string&)':
IIIF.cc:464:24: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
      ( requested_width > width || requested_height > height ) ){
        ~~~~~~~~~~~~~~~~^~~~~~~
IIIF.cc:464:52: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
      ( requested_width > width || requested_height > height ) ){
                                   ~~~~~~~~~~~~~~~~~^~~~~~~~
IIIF.cc:470:27: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
       if( requested_width > max_size || requested_height > max_size ){
           ~~~~~~~~~~~~~~~~^~~~~~~~~~
IIIF.cc:470:58: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
       if( requested_width > max_size || requested_height > max_size ){
                                         ~~~~~~~~~~~~~~~~~^~~~~~~~~~
IIIF.cc:621:27: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
          (requested_width == tw) && (requested_height == th) &&
           ~~~~~~~~~~~~~~~~^~~~~
IIIF.cc:621:55: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
          (requested_width == tw) && (requested_height == th) &&
                                      ~~~~~~~~~~~~~~~~~^~~~~
IIIF.cc:627:27: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
          (requested_width == im_width) && (requested_height == im_height) )
           ~~~~~~~~~~~~~~~~^~~~~~~~~~~
IIIF.cc:627:61: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
          (requested_width == im_width) && (requested_height == im_height) )
                                            ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~

OS used: OracleLinux 8.3 x86_64 Build-tool used: rpmbuild with changed version of IIPSRV Used SRPM: https://download-ib01.fedoraproject.org/pub/epel/7/SRPMS/Packages/i/iipsrv-1.0.0-6.0.el7.src.rpm

ruven commented 3 years ago

These are just warnings - nothing to worry about. But, I've, nevertheless, committed a fix to eliminate these warnings (https://github.com/ruven/iipsrv/commit/6d8390f48fe242369b65ef63539bc15b5b9e0f22)