rwbutler / Updates

📲 Automatically detects app updates and seamlessly prompts users to upgrade.
https://medium.com/swlh/updating-users-to-the-latest-app-release-on-ios-ed96e4c76705
MIT License
289 stars 37 forks source link

NotificationMode is not respected: update UI is always shown #9

Closed pwoods-al closed 3 years ago

pwoods-al commented 4 years ago

Describe the bug Setting the notificationMode via JSON or in code does not change the outcome of the call to Updates.checkForUpdates or the call to UpdatesUI.promptToUpdate. The update UI is always shown no matter what value is stored to the notificationMode configuration setting.

To Reproduce

Updates.updatingMode = .automatically
Updates.notifying = .once

Updates.checkForUpdates { result in
    UpdatesUI.promptToUpdate(result, presentingViewController: self)
}

The update prompt is shown every time the above code is called.

Expected behavior User is only shown the update prompt once.

rwbutler commented 4 years ago

Thanks for letting me know about this - I'll investigate!

NikitaHappilyUnmarried commented 3 years ago

Facing the same issue, the update prompt is always shown.

rwbutler commented 3 years ago

@NikitaHappilyUnmarried @pwoods-al Sorry for the delay with this - could you try v1.2.4? This issue should now be resolved thanks.