search

rxi / lite

A lightweight text editor written in Lua
MIT License
7.42k stars 353 forks source link

Very high memory usage when opening the editor in ~ #208

Open liquidev opened 4 years ago

liquidev commented 4 years ago

My home folder has quite a lot of files, so I suspect that the problem lies somewhere in project indexing (I can't use Ctrl+P when I open lite with $HOME being my project directory). The memory usage goes so high that the system becomes unusable (my entire 16 GiB gets filled), so I think this is a pretty critical issue.

franko commented 4 years ago

I have fixed the problem you are reporting in Lite XL with the corresponding 1.11 release. Lite XL is my fork of Lite with improved font rendering.

I've also sent a pull request with the same fix for rxi's Lite:

https://github.com/rxi/lite/pull/218

The fix I am using is not very elegant, it just stop reading project files when a given predefined limit is reached and the limit is configurable from the config. It is meant as a security measure to avoid eating up all the system's memory. This could be fine if we consider that the problem often occur because of a user's mistake.

We may imagine a more sophisticated solution that keep the project working as expected without using too much memory but this would require a completely new implementation of the project system.

Tmpod commented 4 years ago

There have been a lot of issues opened about this, you should have checked the list before opening this... Either way, yes this is a problem with the project directory scanning, which doesn't have a recursion limit.

A good fix would be to have a configurable limit and a command to resume scanning on a path. This would enable you to lazily load the contents of deeper directories, and could also be integrated in the treeview plugin to resume when you expand a certain folder.