rxri / spicetify-extensions

Collection of custom Spicetify extensions to enhance your Spotify experience
MIT License
146 stars 1 forks source link

bug: Writeify - Cannot display column on playlists #19

Open dcherry88 opened 2 months ago

dcherry88 commented 2 months ago

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

Spotify for Windows (64 bit)
1.2.44.405.g81fd6352
Spicetify v2.37.1
Theme: marketplace
Extensions: djinfo.js, writeify.js
Custom apps: marketplace

📦 Extension name

writeify

📝 Description

Based off documentation there should be an option for toggle within profile menu, but I see no such thing. I can add notes to a song without issue, but I'm unable to get the column in my playlist view so I can see the notes for each of the songs in the playlist.

📸 Screenshots

image

rxri commented 2 months ago

From looking in the code, there's no code for the button in the profile menu. This extension and description were taken from Charlie as it is so not sure what he meant, but that's not a bug!

rxri commented 2 months ago

With the column view, eh... it will break either way and that's not like the best way to "inject" to the tracklist, so I can leave this issue open but won't really bother fixing it. Sorry

dcherry88 commented 2 months ago

Your main picture for this extension is showing the notes column within tracklist/playlist view. If this extension does not provide this functionality, it's pretty misleading on a major feature point that was the reason I decided to try it out. I completely understand if it's not worth the time investment to get working or keep working, but at least update your documentation to state as much. Appreciate you taking a look at this.

rxri commented 2 months ago

but at least update your documentation to state as much

Like I have said, this is not my extension. This repo was taken over from Charlie. Some extensions may work, and some may not. I didn't check if these extensions work or not. The only thing that is maintained is adblockify right now. The only mention about column is in its readme, but not even in the description of this extension.

dcherry88 commented 2 months ago

Totally fair, I understand that you are stating you are simply hosting the code someone else created and not maintaining. Statement of such in at least the readme would be appreciated is all. The fact that you can view the readme within the marketplace and read that information from the readme still makes it misleading. Statement right at the top of "Code no longer maintained and provided as is" would have been more than sufficient for me to not pursue this issue since I would have simply assumed it was something that would not get addressed. Nothing on the GitHub main readme states that only adblockify is being maintained, so while you may state at the bottom that Charlie created these there is nothing that makes it clear that you aren't going to do any further work or fixes to the other extensions.

I appreciate your time today in replying and clarifying though!

image

rxri commented 2 months ago

The fact that you can view the readme within the marketplace and read that information from the readme still makes it misleading

The author of this extension disabled the injecting to tracklist. He did not update the readme. As I have mentioned before, I did not change anything in the description of these extensions.