new styles for message.html

ryanb / letter_opener

Preview mail in the browser instead of sending.

MIT License

3.73k stars 237 forks source link

new styles for message.html #84

Closed gurgeous closed 10 years ago

gurgeous commented 10 years ago

Don't be alarmed, this is actually a small diff apart from whitespace changes. I updated the styles in message.html.erb. Specifically:

added centered container and set width to 800px, which is a reasonable standin for most webmail clients
added border and bg to the pre to highlight whitespace issues
changed the font

Thanks for the great gem!

nashby commented 10 years ago

@gurgeous could you please post "before" and "after" images? Thanks!

gurgeous commented 10 years ago

Sure, how does this look? Some things that aren't obvious in the screenshots:

fixed the pre word wrapping (using white-space: pre-wrap)
the page is centered in the window with a width of 800 px

Before Plain

old_plain

After Plain

new_plain

Before Rich

old_rich

After Rich

new_rich

nashby commented 10 years ago

@gurgeous hmmm, I'm not sure about this new background...

gurgeous commented 10 years ago

Feel free to tweak the colors. I find that the background/border are incredibly helpful for debugging whitespace issues, which are common with ERB templates. I'm color agnostic, though. :)

nashby commented 10 years ago

@gurgeous thanks!

gurgeous commented 10 years ago

Thanks!