ryanccn / moddermore

Share the mods you use with anyone.
https://moddermore.net
GNU Affero General Public License v3.0
65 stars 8 forks source link

Export to zip gets stuck partway through: "Resolving mods" #301

Open allanonmage opened 8 months ago

allanonmage commented 8 months ago

Describe the bug I made a modpack yesterday, and when I tried to download it today to test it, I can't. The pack contains a mix of Modrinth and Curseforge, so I'm using the export as zip functionality.

To Reproduce Steps to reproduce the behavior:

  1. Export as zip
  2. Gets stuck.

On Waterfox, it gets stuck at 175 or 176. On Vivaldi, it gets stuck at 325

Expected behavior An output zip file, or an error message explaining what the problem is.

Desktop (please complete the following information):

Additional context Modpack: https://moddermore.net/list/2eX8EjJqfNKG

allanonmage commented 8 months ago

I saw a bunch of errors in F12 in Waterfox. I'd post it, but it's too big for Github, so I put it on PasteBin: https://pastebin.com/a4xCavC5

I kept looking and the first error is:

`

XHRGEThttps://api.modrinth.com/v2/project/6txNkua3/version?loaders=["fabric"]&game_versions=["1.20.1"]CORS Missing Allow Origin
  |   -- | -- GET | https://api.modrinth.com/v2/project/6txNkua3/version?loaders=["fabric"]&game_versions=["1.20.1"]
Status
429
Too Many Requests
VersionHTTP/2
Transferred509 B (112 B size)
Referrer Policystrict-origin-when-cross-origin

GET https://api.modrinth.com/v2/project/eE2Db4YU/version?loaders=["fabric"]&game_versions=["1.20.1"] [HTTP/2 429 Too Many Requests 42ms]

XHRGET https://api.modrinth.com/v2/project/6txNkua3/version?loaders=["fabric"]&game_versions=["1.20.1"] CORS Missing Allow Origin

GET https://api.modrinth.com/v2/project/6txNkua3/version?loaders=["fabric"]&game_versions=["1.20.1"] Status 429 Too Many Requests VersionHTTP/2 Transferred509 B (112 B size) Referrer Policystrict-origin-when-cross-origin`

so I think Modrinth is complaining that things are coming in too fast. Is there a way to space them out?

ryanccn commented 8 months ago

https://github.com/modrinth/code/issues/2591

allanonmage commented 5 months ago

This is still happening.

Not sure if you saw this: https://github.com/modrinth/code/issues/1398

I don't know the codenames for the various Modrinth softwares, so I picked the first one in the list back in the day.