search

ryankennedy / swagger-jaxrs-doclet

Apache License 2.0
87 stars 136 forks source link

swagger-ui from a folder instead of zip #55

Open ugupta opened 11 years ago

ugupta commented 11 years ago

I am not sure why we would want to keep the swagger-ui as a zip file while you can simply handle it as a folder under resource.

binary (zip) requires special handling and there is no need to put files as zip in git as the compression is already applied by git. It will just waste space and make your deltas larger and larger.

If you provide a folder approach then I can maintain my version of swagger-ui as a folder instead of a zip file.

Please let us know if you are doing any special handling or just for the sake of compression you are putting swagger-ui in a zip file.

I would be happy to work on a patch for this but I would like to know before hand if that would be considered.

ryankennedy commented 10 years ago

It's not the compression benefit I was after originally. More the desire to download the ZIP file, toss it in my resources directory, and call it a day. I think it would be fine to be able to specify either a ZIP or a directory and have the code do the right thing.

conorroche commented 10 years ago

ive added support for this in my fork https://github.com/Carma-Public/swagger-jaxrs-doclet via the swaggerUiPath doclet option