ryanlimdx / pe

0 stars 0 forks source link

Names should be able to include some special characters as well, given the medical nature of the platform. #6

Open ryanlimdx opened 5 months ago

ryanlimdx commented 5 months ago

image.png

image.png

For example, assuming that patients are Singaporean, a common name would include "s/o". However, this could not be included as seen in the first screenshot. Another possibility would be an alias symbol, which is also included on the NRIC. In the above screenshot for "Tan Cheng Bock @ Adrian Tan", "@" meant and is read as "alias", meaning an alternate name or "also known as".

These examples are non-exhaustive, and can cause a major problem if the input is expected to match the legal name of the person, especially in a healthcare setting.

nus-se-script commented 5 months ago

Team's Response

Duplicate of #2339

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Over restrictive name validation to be only alphanumeric - some legal names not allowed

Description Set the context.

This app is used in a clinical context, which mean patient names are usually saved in full. However, some legal names containing non-alphanumeric characters are not allowed to be added into the system.

image.png

Steps to reproduce

  1. Launch the application for the first time to load initial data.
  2. Run add ic/S9987654A p/98887777 n/Ramy s/o Shanmugam g/M b/02-10-99 e/ramy@gmail.com d/General Flu

Expected behaviour

To be able to add this patient and his details.

Actual behaviour

Disallowed.

image.png

Reason for severity

This may cause inconvenience to the doctors who are not able to save their patients' names containing characters like ' or / or -, when they are common amongst people.


[original: nus-cs2103-AY2324S2/pe-interim#2957] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Such issue is of valid concern especially for foreign names that contains special symbols. The team has actually taken note of this particular use case and it was unfortunately not included in the planned enhancements. Hence Accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Given that the examples listed such as "s/o" (and in a similar vein, "d/o") is in fact quite a common part of a name in Singapore, it is more likely that it is of "occasional inconvenience" for severity.Medium rather than "only in very rare situations" of severity.Low. Furthermore, special characters are not just limited to "/". As mentioned in the original bug report, there are other (although not as common) instances as well such as the alias symbol for names on a Singaporean NRIC, which can be found from a quick google search: ![image.png](https://raw.githubusercontent.com/ryanlimdx/pe/main/files/2d468aa1-e7d3-45d1-b0bd-a7feb41fa795.png) ![image.png](https://raw.githubusercontent.com/ryanlimdx/pe/main/files/937ddd9e-4de0-4316-8e7e-037881ba483d.png) Together, these special characters would make a rather common appearance in Singaporean names which are the inferred demographic of patients for the users of this application.