search

ryanmitchell / ti-ext-kitchendisplay

Other
14 stars 8 forks source link

Added Date Time options #41

Closed roydeanjr closed 3 years ago

roydeanjr commented 3 years ago

Added Date Time options to Cards tab selections

ryanmitchell commented 3 years ago

date would need added to array of orders in the Summary.php controller? It should be formatted as follows: $dateVariable->format(lang('system::lang.php.date_format'))

roydeanjr commented 3 years ago

You are correct! I did forget about that modification I had done. My modification was this: $order->order_date = substr($order->order_date, 0, 10); Is that modification ok? It works on my installation.

Or, after looking further, line 217 perhaps is what you are suggesting should be this: 'date' => $order_date->format(lang('system::lang.php.date_format'))

ryanmitchell commented 3 years ago

Yep thats what I mean 👍

ryanmitchell commented 3 years ago

Pushed a couple of changes - let me know if it works ok for you.

ryanmitchell commented 3 years ago

Good spot!

roydeanjr commented 3 years ago

OMG! I was getting confused! I see you got the right code in line 214. I almost did a PR to put lines 127-128 back in and then thought about checking with your files before I did that.

You got everything in that needs to be there. Thank you! I am deleting all the branches and commits that I have in my profile. Will only pull when something needs to be changed.