search

ryanolf / node-sonos-nfc

Access your streaming music through physical NFC tokens, like putting on a CD or record. Great for children and adult aesthetics.
MIT License
36 stars 14 forks source link

Implementing user definable behaviour for resetting shuffle, repeat and crossfade #9

Closed ashenshugarRET closed 2 years ago

ashenshugarRET commented 2 years ago

Pull request to implement user definable behaviour for resetting shuffle, repeat and cross-fade behaviour on starting new music. Also adding in capability of selecting Sonos favourites by name and aligning "tunein" functionality to that within hankhank10's original vinylemulator respository.

ryanolf commented 2 years ago

Hey there @ashenshugarRET, thanks for the pull request. Some of the tests are failing with your changes (you can run rpm test to see). The issue seems to be related to some changes to "tunein" and "favorites" urls that are unrelated to the shuffle, repeat, crossfade functionality. Perhaps you can revert those particular changes? If some of the urls are wrong, that could be a separate pull request. Thanks!

ashenshugarRET commented 2 years ago

I've updated the code for "tunein" and "favorites" to hopefully fix the errors. Please let me know if there are any other problems.

ashenshugarRET commented 2 years ago

I think the error was caused by a mismatch between my updated process_sonos_command.js file and the process_sonos_command.test.js script with respect to the tunein service detection, I have updated the test script to hopefully correct this and to also add in the 'Favorite' service. My updated copy of process_sonos_command.js works perfectly in my install (I simply just copied over my changes to the installed file)