search

rydmike / flex_color_picker

A highly customizable Flutter color picker.
BSD 3-Clause "New" or "Revised" License
198 stars 41 forks source link

Support publishing for ColorCodeField widget #65

Closed nqhhdev closed 1 year ago

nqhhdev commented 1 year ago

Hi Rydmike,

In my project, I used your library and I feel it is very good. Thanks for contributing to flutter community. However, because my project needs some other logic, I want to use more ColorCodeField widget. Can you publish that widget?

Thank you very much.

rydmike commented 1 year ago

Looks good, other than that it enlarges the public API I don't see a reason why not. I'll take a closer look later today, merge and verify all is OK after it, and release a new version if everything checks out.

I hope to have some time to work on major new release of the color picker soonish, have so many things I want to add to it.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (2f0029e) 66.44% compared to head (c8d5a83) 66.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ========================================== - Coverage 66.44% 66.42% -0.02% ========================================== Files 23 23 Lines 2077 2076 -1 ========================================== - Hits 1380 1379 -1 Misses 697 697 ``` | [Impacted Files](https://codecov.io/gh/rydmike/flex_color_picker/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rydmike) | Coverage Δ | | |---|---|---| | [lib/src/widgets/color\_code\_field.dart](https://codecov.io/gh/rydmike/flex_color_picker/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rydmike#diff-bGliL3NyYy93aWRnZXRzL2NvbG9yX2NvZGVfZmllbGQuZGFydA==) | `64.34% <ø> (-0.28%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rydmike). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rydmike)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nqhhdev commented 1 year ago

Looks good, other than that it enlarges the public API I don't see a reason why not. I'll take a closer look later today, merge and verify all is OK after it, and release a new version if everything checks out.

I hope to have some time to work on major new release of the color picker soonish, have so many things I want to add to it.

Thank you for your feedback, I hope you can approve it soon. If you have any comments about PR please tell me.

rydmike commented 1 year ago

Merged and updated package published. CI/CD is building new versions of WEB demo at the moment, takes a few minutes, sometimes even 30 minutes, but not important for using the package right away. Pub:s package analysis can also take 30 mins or so.