ryersondmp / sa11y

Sa11y is an accessibility quality assurance tool that visually highlights common accessibility and usability issues. Geared towards content authors, Sa11y straightforwardly identifies errors or warnings at the source with a simple tooltip on how to fix them.
https://sa11y.netlify.app
Other
280 stars 43 forks source link

Missing Outline Level #56

Closed brianteeman closed 1 year ago

brianteeman commented 1 year ago

It used to be indicated as a red x as still can be seen on the home page screenshots image

It is now an ! which to me doesnt look as clear,

image

adamchaboryk commented 1 year ago

I changed this to be more consistent with the Error annotation icon, which is an exclamation mark. I was going to use ⚠ originally, but it doesn't look good consistently across browsers.

I don't have an issue changing it back to the X.

That said — thoughts?

brianteeman commented 1 year ago

for me either the or the ⚠️look better to me

adamchaboryk commented 1 year ago

i'll change it back to ⚠️ and use the proper entity so it doesn't convert into an emoji ⚠

adamchaboryk commented 1 year ago

Nvm, i used the FontAwesome icon — it will look good. Will update dev shortly

adamchaboryk commented 1 year ago

Looks a lot better now

Updated error icon badge within Page Outline