search

ryersondmp / sa11y

Sa11y is an accessibility quality assurance tool that visually highlights common accessibility and usability issues. Geared towards content authors, Sa11y straightforwardly identifies errors or warnings at the source with a simple tooltip on how to fix them.
https://sa11y.netlify.app
Other
280 stars 43 forks source link

Missing check on hidden images #90

Closed gregrgay closed 2 months ago

gregrgay commented 2 months ago

Since updating to 3.2.0 I'm noticing images contained within a hidden panel are not being picked up. It used to find them. Here's an example on our dev server (login required) of a click & reveal and an accordion panel. Also seems to occur with the flipcard panels as well. I'm guessing it's occurring with all embedded learning objects in the Ektron context.

I've setup some examples at: https://de.spi.torontomu.ca/de_courses/templates/m/?c=211C1E0B83B9C69FA9C4BDEDE203C1E3&m=4&p=40204

adamchaboryk commented 2 months ago

Looks like you're ignoring the .lo container via props: containerIgnore: '[class^=MathJax], .lo',

So the entire container is not being checked for issues:

<div class="lo flip-container" role="region" aria-live="polite" tabindex="0"><div class="flip-card">...</div>

gregrgay commented 2 months ago

Good catch. Ignore .lo should just be for inline styles.