search

ryu1kn / vscode-partial-diff

Visual Studio Code Extension. Take a diff of 2 parts of text(s)
https://marketplace.visualstudio.com/items?itemName=ryu1kn.partial-diff
MIT License
184 stars 15 forks source link

Language selection only works on right-hand side of diff #14

Closed joeskeen closed 6 years ago

joeskeen commented 7 years ago

When comparing larger chunks of text, it's nice to be able to set the language to get syntax highlighting. When comparing files, VSCode does this for us automatically (based on the file type). When setting the language in a partial diff, however, it only sets the language for the right-hand side, leaving the left-hand side as 'plain text'.

image

joeskeen commented 7 years ago

It looks like this is a vscode bug (as I tested it with plaintext files in VSCode), so I'm going to post a bug there. Update: reported as https://github.com/Microsoft/vscode/issues/34408

ryu1kn commented 7 years ago

Thanks for also checking the editor behaviour.

I thought partial diff doesn't set the language for neither sides as I'm not sure if vscode can do syntax highlighting correctly if they have only part of text present in the diff view.

joeskeen commented 6 years ago

https://github.com/Microsoft/vscode/issues/34408 has been fixed, which fixes this issue! :)