search

ryukinix / mal

MAL: A MyAnimeList Command Line Interface [BROKEN: BLAME MyAnimeList]
https://mal.readthedocs.io
Other
109 stars 9 forks source link

Improve inc and dec commands #16

Closed alexkubica closed 7 years ago

alexkubica commented 7 years ago

I think that inc or dec commands should get the number of episodes to change as an argument, for exmaple:

mal inc Naruto 5

Instead of increasing/decreasing one episode at a time.

ryukinix commented 7 years ago

Well, if we can implement this with the condition of mal inc <anime> still do the same for now I'm ok with it. How about add a flag like -n 5? E.g: mal inc Naruto -n 5. For default -n will be 1 for inc and -1 for dec.

alexkubica commented 7 years ago

Yes, it can be done that the number argument is optional and if none is given it will default to one.

alexkubica commented 7 years ago

I'm closing the issue since #26 has been merged, thanks!

ryukinix commented 7 years ago

Just a note: the actual implementation is really the initial description that you made here.

image

The default defined by one don't works because the argument is positional. You think is ok that way or is better something like mal lion inc -n 2 and for default n=1? Would be great retro-compatibility with the old one mal inc lion.