search

s-rah / onionscan

OnionScan is a free and open source tool for investigating the Dark Web.
https://twitter.com/OnionScan
Other
2.89k stars 599 forks source link

Web UI starts by default, but there is no indication of this #112

Closed laanwj closed 2 years ago

laanwj commented 8 years ago

I noticed recently that OnionScan seemed to hang after scanning when invoked via the command line, e.g.:

$ ./osc -scans none -verbose 4hwyik7xxwb6pbvb.onion
2016/11/12 15:46:29 Starting Scan of 4hwyik7xxwb6pbvb.onion
2016/11/12 15:46:29 This might take a few minutes..

--------------- OnionScan Report ---------------
Generating Report for: 4hwyik7xxwb6pbvb.onion

No risks were found.
<Need to Ctrl-C out>

First thought there was a hanging thread, but it turns out that this is because the web UI is started. With -webport 0 the old behavior returns. Should we be more verbose about this?

s-rah commented 8 years ago

Yeah, this was a really quick bug fix I made....basically....we need to keep track of each go routine that we run, so that if then webport isn't active then onionscan will wait for the scans to finish - there is currently no mechanism for doing that.