search

s-rah / onionscan

OnionScan is a free and open source tool for investigating the Dark Web.
https://twitter.com/OnionScan
Other
2.89k stars 599 forks source link

Dispatch onion scans from table #113

Closed laanwj closed 8 years ago

laanwj commented 8 years ago

Create a single table allScans with a mapping from scan name to {protocol.Scanner,bool runByDefault}. Remove the function PerformNextAction with the huge switch statement and instead directly use the map for dispatching. Also use this map in GetAllActions to avoid duplication.

The only user visible impact should be that the scans are re-ordered.

This is just an experiment, don't know if you'll see it as an improvement :)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 31.103% when pulling 01a590c77e89005cbbe8de1f16d1ad711dee073c on laanwj:2016_11_tableify_onionscans into 302e3a4e8827be3a0cf91824f92b58cb85b1de30 on s-rah:onionscan-0.3.

s-rah commented 8 years ago

Choosing to merge this for now since it's a much simpler structure and it lends itself better to future improvements in this space (changing protocols, etc.) I'm not so sure about the ordering, I actually think we should probably come up with a few different sets of scans based on common failures (with web being a baseline since it's the most common, along with ssh and tls) - although I've not yet got a good idea about what that looks like practically.