search

s-yadav / react-number-format

React component to format numbers in an input or as a text.
MIT License
3.9k stars 410 forks source link

Consider removing prop-types dependency #849

Closed vorant94 closed 3 months ago

vorant94 commented 4 months ago

Describe the issue and the actual behavior

prop-types are marked as deprecated as of 2017 and in the upcoming React 19 validation failure will start to be silently ignored. Official React docs suggest replacing it with TypeScript interface to still benefit from build-time checks and reduce the overall bundle size.

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Describe the expected behavior

Please consider removing this lib from the list of dependencies. If you are OK with it, I'll be glad to contribute the fix

s-yadav commented 3 months ago

Actually we can remove it as internall we are no longer using it.

s-yadav commented 3 months ago

Fixed on 5.4.1