search

s1lentq / ReGameDLL_CS

:hammer: Reverse-engineered gamedll (CS 1.6 / CZero)
GNU General Public License v3.0
577 stars 198 forks source link

Critical Flashbang issue #854

Open SmileYzn opened 1 year ago

SmileYzn commented 1 year ago

Hi folks, thanks for hard work!

Some players are reporting that sometimes the first flashbang do not blind player target, and second works.

It is a random problem that sometimes users reported, i'm using latest release 5.22.0.593

I suspect that is related with new trace flags: https://github.com/s1lentq/ReGameDLL_CS/pull/813

Someone can investigate it? It is a critical bug!

justgo97 commented 1 year ago

So this issue is absent in 5.21.0.576? Do you have any plugins interfering with flashbangs?

I don't think this is related to #813 because it doesn't introduce any behavior altering changes let alone inconsistencies to the functioning of flashbang unless I'm missing something

SmileYzn commented 1 year ago

Sorry i guess that is not related with that flags anyway, and server is clean (Without plugins).

To be honest i do not use amx or amxx in servers and do not touch in plugins.

dystopm commented 1 year ago

Hello

There's a chance to downgrade your ReGameDLL version and see if that changes that unexpected behaviour?

SmileYzn commented 1 year ago

Hello

There's a chance to downgrade your ReGameDLL version and see if that changes that unexpected behaviour?

Yes i will try

dystopm commented 1 year ago

Hello There's a chance to downgrade your ReGameDLL version and see if that changes that unexpected behaviour?

Yes i will try

I've just reviewed RadiusFlash implementation, a few partial disassembly codes and a completely decompiled one and found nothing suspicious, plus release changes and things that could interfere. We need more information so we can explore better.

axl303 commented 1 year ago

Some players are reporting that sometimes the first flashbang do not blind player target, and second works.

I can confirm this also. Plus to this I can add that the flash time kinda stack when there are multiple flashes thrown and you are blind too much in some cases (not sure if it's from amxx plugins).

Before 2 years I was playing on some pub servers using AMXX, so I installed a server on localhost with metamod only (pure server) to be sure that isn't from some amxx plugin or metamod plugin and the effect was the same.

The effect happens sometimes (from 50 maps I can say 1-5 times per 50 maps) not sure tho. From my experience.

I will be happy to test and give more information if needed.

bruxos commented 1 year ago

Here on my server is having the same problem.

dystopm commented 1 year ago

Here on my server is having the same problem.

ReGameDLL version, steps to reproduce the issue, etc

NiceFeatures commented 1 year ago

Here on my server is having the same problem.

ReGameDLL version, steps to reproduce the issue, etc

Same problem here, using:

ReHLDS version 3.13.0.788 ReGameDLL version 5.22.0.593 ReAPI version 5.22.0.254 Amxmodx version 1.10 - build 5467

The bug occasionally occurs when someone throws a flash at you and just nothing happens, sometimes just the first one doesn't blind and the second causes the blindness, the only rule is that this bug never happened to me testing flash on myself, it was always another player .

dystopm commented 1 year ago

Here on my server is having the same problem.

ReGameDLL version, steps to reproduce the issue, etc

Same problem here, using:

ReHLDS version 3.13.0.788 ReGameDLL version 5.22.0.593 ReAPI version 5.22.0.254 Amxmodx version 1.10 - build 5467

The bug occasionally occurs when someone throws a flash at you and just nothing happens, sometimes just the first one doesn't blind and the second causes the blindness, the only rule is that this bug never happened to me testing flash on myself, it was always another player .

Thanks for your response, just one doubt

First flashbang of the round, map, connection, or another unknown behaviour?

NiceFeatures commented 1 year ago

Here on my server is having the same problem.

ReGameDLL version, steps to reproduce the issue, etc

Same problem here, using: ReHLDS version 3.13.0.788 ReGameDLL version 5.22.0.593 ReAPI version 5.22.0.254 Amxmodx version 1.10 - build 5467 The bug occasionally occurs when someone throws a flash at you and just nothing happens, sometimes just the first one doesn't blind and the second causes the blindness, the only rule is that this bug never happened to me testing flash on myself, it was always another player .

Thanks for your response, just one doubt

First flashbang of the round, map, connection, or another unknown behaviour?

From the complaints of my servers, it was always the first flash launched by the player in the round, for example I threw a flash at you and you at me, the first one does not blind any of the 2, the second causes blindness.

NiceFeatures commented 1 year ago

Included a video

Vídeo demonstration

RauliTop commented 1 year ago

Included a video

Vídeo demonstration

Post your meta plugins and amxx plugins list also.

@SmileYzn how does it work with the downgrade?

NiceFeatures commented 1 year ago

Protocol version 48 Exe version 1.1.2.7/Stdio (cstrike) ReHLDS version: 3.13.0.788-dev Build date: 07:36:33 Jul 12 2023 (3378) Build from: https://github.com/dreamstalker/rehlds/commit/f955b07

AMX Mod X 1.10.0.5467 (http://www.amxmodx.org) Authors: David "BAILOPAN" Anderson, Pavol "PM OnoTo" Marko Felix "SniperBeamer" Geyer, Jonny "Got His Gun" Bergstrom Lukasz "SidLuke" Wlasinski, Christian "Basic-Master" Hammacher Borja "faluco" Ferrer, Scott "DS" Ehlert Compiled: Jan 21 2023 20:27:33 Built from: https://github.com/alliedmodders/amxmodx/commit/27f451a Build ID: 5467:27f451a Core mode: JIT+ASM32

Currently loaded plugins: id name version author url file status
[ 1] 0 mdbBans 4.8 Desikac unknown mdbBansEN.a running
[ 2] 1 Admin Base 1.10.0.546 AMXX Dev Team admin.amxx running
[ 3] 2 MG Booster 1.0 blackjack unknown baseamx.amx running
[ 4] 3 Admin Commands 1.10.0.546 AMXX Dev Team admincmd.am running
[ 5] 4 Admin Help 1.10.0.546 AMXX Dev Team adminhelp.a running
[ 6] 5 Menus Front-End 1.10.0.546 AMXX Dev Team menufront.a running
[ 7] 6 Commands Menu 1.10.0.546 AMXX Dev Team cmdmenu.amx running
[ 8] 7 Players Menu 1.10.0.546 AMXX Dev Team plmenu.amxx running
[ 9] 8 Teleport Menu 1.10.0.546 AMXX Dev Team telemenu.am running
X[ 10] 9 Maps Menu 1.10.0.546 AMXX Dev Team mapsmenu.am running [ 11] 10 Plugin Menu 1.10.0.546 AMXX Dev Team pluginmenu. running
[ 12] 11 Admin Chat 1.10.0.546 AMXX Dev Team adminchat.a running
[ 13] 12 Anti Flood 1.10.0.546 AMXX Dev Team antiflood.a running
[ 14] 13 Admin Votes 1.10.0.546 AMXX Dev Team adminvote.a running
[ 15] 14 NextMap 1.10.0.546 AMXX Dev Team nextmap.amx running
[ 16] 15 TimeLeft 1.10.0.546 AMXX Dev Team timeleft.am running
[ 17] 16 Pause Plugins 1.10.0.546 AMXX Dev Team pausecfg.am running
[ 18] 17 Stats Configuration 1.10.0.546 AMXX Dev Team statscfg.am running
[ 19] 18 Restrict Weapons 1.10.0.546 AMXX Dev Team restmenu.am running
[ 20] 19 StatsX 1.10.0.546 AMXX Dev Team statsx.amxx paused
X[ 21] 20 Reapi Fix Shot 1.0.0 fl0wer unknown reapifixsho running [ 22] 21 Accuracy FIX by allyso 2.2.9 allyson accuracyfix running
[ 23] 22 Slim Pug PugMod v2 7.5 iceeedR www.iceeedr.com.br SlimPug.amx running
[ 24] 23 Center Msg Fix 0.4 mx?! CenterMsgFi running
[ 25] 24 Enemy Radar 1.32 AdaskoMX enemyradar. paused
[ 26] 25 Kill Assist 1.5 xTroyde5 KillAssist. running
[ 27] 26 AutoUpdater 1.5 SmileY & iceeedR Updater.amx running
27 plugins, 25 running

Regarding downgrade, going back to version 5.21.0.556 solved the problem

RauliTop commented 1 year ago

Tested on 5.23 and any problem with flashbangs.

@NiceFeatures give us steps to reproduce the issue on the video.

NiceFeatures commented 12 months ago

Tested on 5.23 and any problem with flashbangs.

@NiceFeatures give us steps to reproduce the issue on the video.

Basically, if you throw smoke while doing strafe (A-D A-D) very quickly the bug occurs, if you play standing still or moving forwards or backwards everything is normal.

SmileYzn commented 12 months ago

Included a video Vídeo demonstration

Post your meta plugins and amxx plugins list also.

@SmileYzn how does it work with the downgrade?

Honestly, no. Same problem of flashbug here

dystopm commented 12 months ago

@SmileYzn Is the behavior the same in old versions as well? Is it too much work to downgrade until you find a stable version related to this bug? We need to be sure of that, because if downgrading doesn't work to find a bug-free version, then we shouldn't lock in our investigation in changes from one version to another.

NiceFeatures commented 12 months ago

Here problem was solved downgrading to RGDLL 5.21.0.556

dystopm commented 12 months ago

Here problem was solved downgrading to RGDLL 5.21.0.556

@SmileYzn can you confirm this? So I can figure it out by looking those changes in particular

SmileYzn commented 12 months ago

Here problem was solved downgrading to RGDLL 5.21.0.556

Same result, downgrade seems to be fixed it

dystopm commented 12 months ago

In summary, issue started from 5.21.0.556 to 5.21.0.575 - please confirm this. I'll be doing a research on it, might be a really tiny detail

SmileYzn commented 12 months ago

In summary, issue started from 5.21.0.556 to 5.21.0.575 - please confirm this. I'll be doing a research on it, might be a really tiny detail

Yes

iceeedR commented 7 months ago

Still persist's on latest build...

SmileYzn commented 7 months ago

The problem can be in this function:

https://github.com/s1lentq/ReGameDLL_CS/blob/5d2174fbbf546f033118bc6d65d55d2166f66980/regamedll/dlls/combat.cpp#L88

This is the only thing that can affect flash bug, since ScreenFade is not being called when flash bug appears

#ifdef REGAMEDLL_FIXES
        vecSpot = pPlayer->EyePosition();
#else
        // NOTE: See CBasePlayer::BodyTarget
        vecSpot = pPlayer->BodyTarget(vecSrc);
#endif

That can have a variable (cvar) to make default behavior, or new fix