search

s32x / anirip

:clapper: A Crunchyroll show/season ripper
MIT License
158 stars 37 forks source link

More efficient subtitle download #38

Closed turtletowerz closed 5 years ago

turtletowerz commented 5 years ago

This (appears to be) a more efficient method for downloading subtitles for Crunchyroll episodes. Instead of using the traditional method of grabbing the episode subtitles, decrypting, and then formatting them, this method grabs configuration data on the episode's page and download the raw subtitles.

There are a few things I would like to note: 1) These subtitles are (almost always) downloaded from VRV, not Crunchyroll. I think this results in the subtitle font being slightly different, but I don't really know 2) While I successfully downloaded multiple seasons of shows without and issues using this new method, I only tested it on Windows. It's probably a good idea to test it before considering merging. 3) I also cannot confirm that subtitle languages outside of English and Japanese will work, as I have not tested that thoroughly enough

turtletowerz commented 5 years ago

Please let me know if there is anything I should change or fix, as this may have been a little rushed in terms of quality

s32x commented 5 years ago

That works for me man. Thanks so much for the contribution. Eventually/Ideally, I'd like to move everything to VRV since it's a no brainer and has more content... But can't really find the time lately for this project :\

turtletowerz commented 5 years ago

I plan on finding a couple more things that could be improved, but it's just a hobby at the moment so I can't guarantee I'll find anything major. I'll also continue to improve the subtitle part as I find out more about the different supported languages.