search

s3rvac / weechat-notify-send

A WeeChat script that sends highlight and message notifications through notify-send.
MIT License
176 stars 19 forks source link

add to weechat.org #1

Closed ghost closed 8 years ago

ghost commented 8 years ago

please add the script to https://weechat.org/scripts/ so that weechat can install and update the script natively

s3rvac commented 8 years ago

Thank you for the idea. I gave this a lot of thought when I made the plugin, and I decided not to do that. The reason is that according to the weechat script pages, one should not submit scripts that:

There is notify_send.pl, which is pretty similar to my plugin, and also uses the same name. Therefore, I did not even try to submit my plugin, because the page says that such scripts will be rejected.

It is still possible to install the script manually. I hope this is not too inconvenient.

TRSx80 commented 4 years ago

Coming at this from a different perspective, I found your script by searching for "weechat jabber notify" which led me to your blog post and ultimately, here.

I saw the script of the same name at Weechat (and inside weechat using /scripts command) and thought they were the same. It was only when I was trying to change settings that I noticed the one from Weechat repository is a perl script (/set plugins.var.perl.notify_send.*) and yours of course is Python. :)

So another reason to consider renaming would be to avoid confusion. How about:

or something like that?

As far as being "the same" there are quite a number of "notification" scripts there, in fact there is a whole tag category "notify."

OTOH, maybe it's more confusing to people to make such change after all this time. I dunno. I guess it would be easy to leave a redirect and short explanation from this repository to the new one...

At any rate, certainly you are free to decide to do whatever you want. I just thought I would register my $0.02. :smile:

Thank you for work, and most importantly for sharing it under open source license like a civilized person! :smile:

Cheers!

EDIT: After writing this, I went to uninstall the "other" notify-send and realized upon closer look that (at least from within Weechat) it shows up as .pl extension. So I don't know if they (Weechat) consider the extension to be "different" enough, or if the whole script name needs to be different (and I didn't spend any time to look up their rules regarding). Anyway... thanks again! :smile: